Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier eslint cleanup #1416

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Prettier eslint cleanup #1416

merged 4 commits into from
Mar 7, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Mar 7, 2024

Closes #1384

  • Updates prettier version
  • Cleans up how ESLint and Prettier play together
  • Creates scripts in package.json for linting and prettifying
  • Runs eslint and prettier on all files, autofixing all the things
  • Introduces a new Github Action for running lint job and pretty job

@adamgall adamgall requested review from mudrila and Da-Colon March 7, 2024 18:04
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for fractal-framework-dev ready!

Name Link
🔨 Latest commit ad98cf4
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-dev/deploys/65ea041aa937ff00089c95df
😎 Deploy Preview https://deploy-preview-1416.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall self-assigned this Mar 7, 2024
Da-Colon
Da-Colon approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamgall adamgall merged commit 11303a7 into develop Mar 7, 2024
7 checks passed
@adamgall adamgall deleted the prettier-eslint-cleanup branch March 7, 2024 20:48
@adamgall adamgall mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Da-Colon Da-Colon Da-Colon approved these changes

@mudrila mudrila mudrila approved these changes

Assignees

@adamgall adamgall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run ESLint/Prettier as a Github Action
3 participants
@adamgall @mudrila @Da-Colon